[autobackport: sssd-2-11] Tests: Fix ipa multihost test_authentication_indicators#8528
Conversation
Provide sleep time to test Reviewed-by: Jakub Vávra <jvavra@redhat.com> (cherry picked from commit a6d0f0c)
jakub-vavra-cz
added
Accepted
Tests
Trivial
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces a time.sleep(5) call within the test_authentication_indicators function in src/tests/multihost/ipa/test_misc.py. This change appears to be a pragmatic fix to address potential timing issues or race conditions in the test environment, ensuring that the ipa sudorule-add-user command has sufficient time to propagate before subsequent commands are executed. While adding fixed delays to tests can sometimes indicate underlying synchronization problems or lead to slower test execution, this specific modification, being a test-level adjustment for stability, does not present any issues that meet the 'high' or 'critical' severity criteria for the core codebase or test framework itself.
3 participants
This is an automatic backport of PR#8525 Tests: Fix ipa multihost test_authentication_indicators to branch sssd-2-11, created by @aborah-sudo.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
a6d0f0c - Tests: Fix ipa multihost test_authentication_indicators
Backported commits
Original Pull Request Body
Provide sleep time to test